Skip to content

fix(express): wait for app cfg before user fetch#5

Merged
mhamann merged 5 commits into
mainfrom
class-refactor
Nov 9, 2022
Merged

fix(express): wait for app cfg before user fetch#5
mhamann merged 5 commits into
mainfrom
class-refactor

Conversation

@mhamann
Copy link
Copy Markdown
Contributor

@mhamann mhamann commented Nov 9, 2022

This essentially fixes one bug surrounding the case for fetching or updating user info, but in the process this change:

  • Refactors SDK to use classical inheritance in order to make its structure clearer and easier to understand
  • Adds test mocks for reliable and repeatable runs
  • Enables infinite retries when fetching app configs just in case of network/infra issues
  • Waits for app config to load when attempting to fetch user profile info, but doesn't wait forever

@mhamann mhamann merged commit ac93fcd into main Nov 9, 2022
@mhamann mhamann deleted the class-refactor branch November 9, 2022 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant